[wp-trac] [WordPress Trac] #37305: Custom Logo: output invalid according to the W3C

WordPress Trac noreply at wordpress.org
Tue Dec 5 22:54:03 UTC 2017


#37305: Custom Logo: output invalid according to the W3C
--------------------------+------------------------------
 Reporter:  henry.wright  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Themes        |     Version:  4.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by zodiac1978):

 Replying to [comment:11 tfrommen]:
 > I just uploaded a new patch, refreshed for current trunk, and with just
 the removal of the `itemprop` attribute, as suggested and what makes the
 most sense to me.

 Hi Thorsten, there is another `itemprop` for the logo here:
 https://github.com/WordPress/WordPress/blob/aaf99e691391cfceb004d848450dbbf3344b1bee
 /wp-includes/general-template.php#L897

 Replying to [comment:9 markcallen]:
 > It would be more appropriate to remove the itemprop attributes from the
 link and img tag and provide a facility for developers to add them
 (filters and/or function args).

 I think this would be the best way. If you are a theme developer and you
 know that you have added `itemscope itemtype="http://schema.org/WebPage"`
 to the `html` element for example, you can use the filter or the parameter
 to add this feature. But the default should be to not add this attribute.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37305#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list