[wp-trac] [WordPress Trac] #41057: Update PHP codebase per WordPress PHP Coding Standards

WordPress Trac noreply at wordpress.org
Tue Dec 5 06:20:39 UTC 2017


#41057: Update PHP codebase per WordPress PHP Coding Standards
----------------------------+---------------------
 Reporter:  netweb          |       Owner:  pento
     Type:  task (blessed)  |      Status:  closed
 Priority:  normal          |   Milestone:  5.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:  early commit    |     Focuses:
----------------------------+---------------------

Comment (by netweb):

 Replying to [comment:89 netweb]:
 > Replying to [comment:84 pento]:
 > > ... we still need write a `grunt` task to do the `phpcbf` and `phpcs`
 runs.
 >
 > Added Grunt tasks `grunt phpcs` and `grunt phpcbf` in
 [attachment:41057-grunt.diff]
 >
 > > We can make `phpcbf` run a required Travis job immediately (run
 `phpcbf`, fail if there are changes). `phpcs` will have to stay as an
 `allowed_failure` job until all of the manual fixes are done.
 >
 > Will do the Travis CI side of things in a separate patch

 Replying to [comment:107 pento]:
 > @jrf has kindly pushed her [https://github.com/WordPress-Coding-
 Standards/WordPress-Coding-Standards/tree/feature/new-multi-line-comment-
 formatting-sniffs in-progress work] on the multi-line comment indenting
 fix - docblocks appear to be working correctly, but other multi-line
 comments are still in progress.

 I've now got `phpcbf` and `phpcs` patches for Travis CI jobs and Grunt
 tasks refreshed here locally, thinking these should be split to another
 ticket, I'll create that soonish, ping me if you'd like a peak at the
 patches in the meantime.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41057#comment:110>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list