[wp-trac] [WordPress Trac] #31590: Comment reply links can cause JS error on slow connections/large pages

[WordPress Trac]

#31590: Comment reply links can cause JS error on slow connections/large pages
---------------------------+-----------------------------------
 Reporter:  peterwilsoncc  |       Owner:  rachelbaker
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  5.0
Component:  Comments       |     Version:  2.7
 Severity:  normal         |  Resolution:  fixed
 Keywords:  has-patch      |     Focuses:  javascript, template
---------------------------+-----------------------------------
Changes (by peterwilsoncc):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"42360"]:
 {{{
 #!CommitTicketReference repository="" revision="42360"
 Comments: Modernise JavaScript for comment reply links.

 Update the comment reply JavaScript to be unobtrusive and use events
 rather than inline `onclick` attributes.

 Along with bringing the code into the 2010s this prevents an edge-case in
 which `addComment.moveForm()` could be called before the JavaScript has
 loaded.

 Props peterwilsoncc, bradparbs.
 Fixes #31590.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31590#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform