[wp-trac] [WordPress Trac] #42773: Plugin/Theme editor does not return sufficient information when loopback request fails

WordPress Trac noreply at wordpress.org
Fri Dec 1 23:46:47 UTC 2017


#42773: Plugin/Theme editor does not return sufficient information when loopback
request fails
-------------------------+-----------------------------
 Reporter:  jamesgol     |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  Plugins      |    Version:  4.9
 Severity:  normal       |   Keywords:
  Focuses:               |
-------------------------+-----------------------------
 The sandbox feature of the theme/plugin editor in 4.9 is a step in the
 right direction.  Unfortunately there are many situations where the
 loopback request fails and there is no indication back to the user why
 that happened.  The cURL/WP_Error response is just tossed away and a
 generic message is sent.  Will attach a patch that at least returns the
 error message back to the user.

 Additional improvements could be made, but I don't have the time to
 implement them:
 Have a loopback test run before the file is saved to at least be sure that
 is available (save the result in a transient with a 60 sec ttl)
 If that loopback fails, pop up a notice that the sandboxing feature is
 unavailable but have a checkbox to allow the user to force the edit to
 save.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42773>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list