[wp-trac] [WordPress Trac] #41760: wp_list_comments callback params

[WordPress Trac]

#41760: wp_list_comments callback params
--------------------------+------------------------------
 Reporter:  milana_cap    |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Comments      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |     Focuses:  template
--------------------------+------------------------------

Comment (by ayeshrajans):

 It certainly makes sense to have semantic parameter order I totally agree.
 However, I'm afraid changing the callback arguments will introduce a lot
 of backwards incompatibility issues, and I doubt the implementors will be
 happy we changed the parameter order purely for the semantic purposes.

 https://github.com/search?l=PHP&q=wp_list_comments+callback%3D&type=Code&utf8=✓
 here is a fuzzy GitHub search for the function call with callback
 parameter.

 Both class methods you mentioned are protected methods, which means if we
 change the parameter order of those two methods, we would only need to
 change the current class and it's subclasses.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41760#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform