[wp-trac] [WordPress Trac] #29684: Add get_main_site_id() function

WordPress Trac noreply at wordpress.org
Wed Aug 30 20:20:32 UTC 2017


#29684: Add get_main_site_id() function
-------------------------------------------------+-------------------------
 Reporter:  rmccue                               |       Owner:  jeremyfelt
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.9
Component:  Networks and Sites                   |     Version:  3.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests ms-roadmap  |     Focuses:  multisite
-------------------------------------------------+-------------------------

Comment (by flixos90):

 [attachment:29684.10.diff] changes the following:
 * Rename the filter to `pre_get_main_site_id()` and adjust the docs
 accordingly to indicate it's a short-circuiting filter.
 * Remove the check for whether `$network->blog_id` is set.
 * Remove two tests (including the failing one) that actually weren't
 really useful for testing the function since they actually would need to
 rely on network switching to have a purpose (which we don't have in core).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29684#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list