[wp-trac] [WordPress Trac] #38645: Improve roles reinit when switching between sites

[WordPress Trac]

#38645: Improve roles reinit when switching between sites
--------------------------------------+------------------------
 Reporter:  johnjamesjacoby           |       Owner:  flixos90
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  4.9
Component:  Role/Capability           |     Version:  4.7
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+------------------------

Comment (by jeremyfelt):

 [attachment:38645.4.diff] is looking good.

 * We're making the change to `WP_User::for_site()` in #36961, so we can do
 the same here.
 * I have the same concerns in this ticket with removing the `__call()` and
 causing a fatal error for anyone using `_init()`. We can deprecate and
 leave the call in there, IMO.
 * In `get_roles_data()`, `remove_action()` should only use 3 parameters.

 I'd like to see feedback from @johnjamesjacoby on the latest changes. It'd
 also be good to hear from @mnelson4 and @charliespider, since they brought
 up issues on #23016 that helped lead to this ticket.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38645#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform