[wp-trac] [WordPress Trac] #37923: Introduce shared wp_blogmeta database table for multisite installation
WordPress Trac
noreply at wordpress.org
Wed Aug 23 12:10:22 UTC 2017
#37923: Introduce shared wp_blogmeta database table for multisite installation
-------------------------------------------------+-------------------------
Reporter: johnjamesjacoby | Owner:
Type: feature request | spacedmonkey
Priority: normal | Status: assigned
Component: Networks and Sites | Milestone: 4.9
Severity: normal | Version:
Keywords: has-patch has-unit-tests needs- | Resolution:
testing ms-roadmap | Focuses: multisite
-------------------------------------------------+-------------------------
Comment (by flixos90):
@spacedmonkey Some notes on the latest patch:
* I think you forgot to upload the actual `is_site_meta_supported()`
function itself. :)
* As discussed yesterday, let's not populate the setting in
`populate_network()` as this would cause the setting to be populated on
every network. Instead let's ensure the setting is populated during the
multisite bootstrap process. I think adding `add_action( 'ms_loaded',
'is_site_meta_supported', 1, 0 )` would be a simple way to do so. This
ensures the "global" setting is set at all times, as it populates it on-
the-fly if it isn't set.
* With the suggested `$force` parameter of `is_site_meta_supported()`, the
logic in `wp-admin/includes/upgrade.php` can be simplified as well: The
two lines currently there could be replaced with a simple call to
`is_site_meta_supported( true )`.
* I'm not sure the function should be in `functions.php` just because
`global_terms_enabled()` is. Site meta is entirely multisite
functionality, so it may be better in `ms-blogs.php`. @jeremyfelt
@johnjamesjacoby What's your thought on this?
Regarding the other ticket, I'd rather deal with it separately. We
probably don't want that discussion to delay the merge of site meta. :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37923#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list