[wp-trac] [WordPress Trac] #37923: Introduce shared wp_blogmeta database table for multisite installation

[WordPress Trac]

#37923: Introduce shared wp_blogmeta database table for multisite installation
-------------------------------------------------+-------------------------
 Reporter:  johnjamesjacoby                      |       Owner:
     Type:  feature request                      |  spacedmonkey
 Priority:  normal                               |      Status:  assigned
Component:  Networks and Sites                   |   Milestone:  4.9
 Severity:  normal                               |     Version:
 Keywords:  has-patch has-unit-tests needs-      |  Resolution:
  testing ms-roadmap                             |     Focuses:  multisite
-------------------------------------------------+-------------------------

Comment (by flixos90):

 @boonebgorges Ah okay, I didn't have in mind that `get_metadata()` can
 already return false. In that case, I agree we should follow the pattern
 for "invalid" requests. For consistency it may be better to always return
 a result so that the code calling these functions wouldn't have to
 consider this `false` special return value - on the other hand we'd need
 another way to check if a meta request was successful or not. But that
 could be part of another discussion.

 @spacedmonkey I'm good with the current state of the patch.
 * A minor thing is the `@access private` in `_prime_site_caches()` needs
 to remain there, I previously only referred to the other access modifiers,
 as access modifiers should only be used in core, if it's a regular
 function that should be indicated as private (note that this is a pattern
 we shouldn't ever use again, but there are several legacy functions that
 do this).
 * The other is that we'd probably need to check for `site_meta_supported`
 before deleting site metadata in `wpmu_delete_blog()`.
 * Let's discuss the approach of using a network option to detect the table
 in today's office hours. We can also briefly ask for feedback on whether
 we should load `formatting.php` earlier or move the function out of it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37923#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform