[wp-trac] [WordPress Trac] #37923: Introduce shared wp_blogmeta database table for multisite installation

WordPress Trac noreply at wordpress.org
Mon Aug 21 12:23:37 UTC 2017


#37923: Introduce shared wp_blogmeta database table for multisite installation
-------------------------------------------------+-------------------------
 Reporter:  johnjamesjacoby                      |       Owner:
     Type:  feature request                      |  spacedmonkey
 Priority:  normal                               |      Status:  assigned
Component:  Networks and Sites                   |   Milestone:  4.9
 Severity:  normal                               |     Version:
 Keywords:  has-patch has-unit-tests needs-      |  Resolution:
  testing ms-roadmap                             |     Focuses:  multisite
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 [https://core.trac.wordpress.org/attachment/ticket/37923/37923.4.diff
 37923.4.diff]
 Key changes

 - No longer move formatting.php in wp-settings.php. Only move
 `sanitize_key` as it is used in meta api
 - Moved *_site_meta to ms-blogs.php next to *_blog_option
 - Fixed formatting
 - Remove `blog_id` references from `wp_site_query` as not needed until
 meta query.

 I don't agree with the use of get_network_option. I personally prefer
 network_options of course, but it is a function that will remain in core
 forever and can now just be considered a helper function.

 As for get_site_meta returning false if not supported, this is how
 get_term_meta works. Forcing false is a nice way to return that site meta
 is disabled and not result in false positives.

 I do not know where the datatbase version numbers come from. @jeremyfelt
 can you shine some light on this?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37923#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list