[wp-trac] [WordPress Trac] #40187: The tag cloud should output a list

[WordPress Trac]

#40187: The tag cloud should output a list
--------------------------+------------------------------------------------
 Reporter:  afercia       |       Owner:  davidakennedy
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  4.9
Component:  Taxonomy      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  tag-cloud     |     Focuses:  ui, accessibility, administration
  has-patch               |
--------------------------+------------------------------------------------
Changes (by audrasjb):

 * keywords:  tag-cloud needs-patch => tag-cloud has-patch


Comment:

 Hello,

 I wordked on a fix for this ticket.
 Here is a short summary of the changes:

 - wp-admin/includes/class-wp-press-this.php & wp-admin/includes/meta-
 boxes.php
 Replace div with unordered list, keeping the same classname.

 - wp-admin/js/tags-box.js
 Replace span element with list-item element.
 Replace "span" variable name with "item" for consistency, in both code and
 inline documentation

 - wp-admin/css/edit.css & wp-admin/css/press-this.css
 Add some styles to prevent default css rules for list-items to be
 applicated
 Add some display: inline-block stuff for list items
 Replace span with li in both desktop and media-queries CSS's

 All is tested in both edit-post' tag metabox and Press this. Seems to be
 ok.

 That was very interesting to work on both PHP, CSS and JS :)
 I hope that all is ok with my diff file and that I forgot nothing.

 Let me know if anything is wrong, I'll be happy to do better the next
 time. This is my very first steps on Trac so dont hesitate to tell me if I
 doing some mistakes in Trac use :)

 Best regards,
 Jb

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40187#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform