[wp-trac] [WordPress Trac] #39030: Pass post object or post ID to post_thumbnail_size filter

WordPress Trac noreply at wordpress.org
Fri Aug 18 18:14:14 UTC 2017


#39030: Pass post object or post ID to post_thumbnail_size filter
-------------------------------------------------+-------------------------
 Reporter:  wido                                 |       Owner:
     Type:  enhancement                          |  NathanAtmoz
 Priority:  normal                               |      Status:  assigned
Component:  Post Thumbnails                      |   Milestone:  4.9
 Severity:  normal                               |     Version:
 Keywords:  good-first-bug has-patch has-unit-   |  Resolution:
  tests                                          |     Focuses:  template
-------------------------------------------------+-------------------------
Changes (by flixos90):

 * keywords:  good-first-bug has-patch needs-unit-tests => good-first-bug
     has-patch has-unit-tests
 * version:  4.7 =>


Comment:

 [attachment:39030.diff] passes the post ID instead of post object, to have
 consistency with the other filters in the function, and also in order to
 prevent the filter from changing object properties on the original
 instance.

 Tests for the filter usage including the new parameter have been added
 too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39030#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list