[wp-trac] [WordPress Trac] #22287: Plugin in another plugin folder causes Activate link to be wrong on Download

[WordPress Trac]

#22287: Plugin in another plugin folder causes Activate link to be wrong on
Download
--------------------------------------+------------------------------
 Reporter:  joehoyle                  |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Upgrade/Install           |     Version:  3.4
 Severity:  normal                    |  Resolution:
 Keywords:  needs-patch dev-feedback  |     Focuses:
--------------------------------------+------------------------------
Changes (by jdgrimes):

 * keywords:  needs-patch => needs-patch dev-feedback


Comment:

 @ideag Yeah, it seems that there are really three solutions:

 - Sort the results from `get_plugins()`.
 - Add a parameter to `get_plugins()` to skip checking in subdirectories.
 - Don't use `get_plugins()` at all, as in
 `Plugin_Upgrader::check_package()`.

 I favor the second option, since it avoids looking into the subdirectories
 unnecessarily. (The third option would do that as well, however, it would
 require duplicate logic.)

 But maybe @dd32 and @SergeyBiryukov would like to give their opinion.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22287#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform