[wp-trac] [WordPress Trac] #39692: Fix missing assignment of menus on theme switch

[WordPress Trac]

#39692: Fix missing assignment of menus on theme switch
--------------------------------------------+-----------------------
 Reporter:  melchoyce                       |       Owner:
     Type:  enhancement                     |      Status:  assigned
 Priority:  normal                          |   Milestone:  4.9
Component:  Menus                           |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch needs-testing commit  |     Focuses:
--------------------------------------------+-----------------------
Changes (by westonruter):

 * keywords:  has-patch needs-testing => has-patch needs-testing commit


Comment:

 @obenland ok, [attachment:39692.7.diff] makes those changes. I've updated
 the unit tests to make use of the new function as oppose to using the
 private function and manipulating theme mods and options.

 I've also added updated the test runner to test more
 [https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-
 permutations/blob/master/tests/nav-menus/scenarios.json scenarios], using
 three methods to switch themes: WP-CLI, themes admin screen, and the
 Customizer: https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-
 permutations/blob/master/tests/nav-menus/runner.php

 Using headless Chrome to script the activation of a theme via the
 Customizer and admin screen:
 * [https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-
 permutations/blob/master/tests/nav-menus/switch-theme-via-admin.js switch-
 theme-via-admin.js]
 * [https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-
 permutations/blob/master/tests/nav-menus/switch-theme-via-customizer.js
 switch-theme-via-customizer.js]

 This is good for to you commit from my view, though per above there may be
 some tweaks to the group slugs.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39692#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform