[wp-trac] [WordPress Trac] #39692: Fix missing assignment of menus on theme switch
WordPress Trac
noreply at wordpress.org
Mon Aug 7 22:17:10 UTC 2017
#39692: Fix missing assignment of menus on theme switch
-------------------------------------+-----------------------
Reporter: melchoyce | Owner:
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.9
Component: Menus | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+-----------------------
Comment (by joyously):
I still think the groups are not right being
{{{
$common_slug_groups = array(
array( 'header', 'main', 'navigation', 'primary', 'top' ),
array( 'bottom', 'footer', 'secondary', 'subsidiary' ),
array( 'social' ),
// TODO: Find a second slug or remove, since locations with same slug
are already mapped.
);
}}}
The themes I have seen will typically have two or more menus at the top of
the page and perhaps one at the bottom. So, like I said before, this makes
more sense: (`top` is typically right below the admin bar and not the main
menu)
{{{
$common_slug_groups = array(
array( 'header', 'main', 'primary' ),
array( 'secondary', 'subsidiary', 'top', 'custom' ),
array( 'bottom', 'footer' ),
);
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39692#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list