[wp-trac] [WordPress Trac] #39692: Fix missing assignment of menus on theme switch

[WordPress Trac]

#39692: Fix missing assignment of menus on theme switch
-------------------------------------------------+-------------------------
 Reporter:  melchoyce                            |       Owner:
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9
Component:  Menus                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by westonruter):

 @obenland I'm creating a suite of child themes for testing and debugging
 to confirm that the theme switching is resulting in nav menus being
 assigned to the new locations as expected: https://github.com/xwp/wp-
 theme-nav-menu-widget-sidebar-permutations

 Right now there is one test for a theme that has nav menu locations
 (primary, secondary) and another theme that has nav menu locations (top,
 footer) and it checks to confirm that the menus assigned to locations in
 the former theme get re-assigned to the locations in the latter theme. So
 far, so good! ✅ The tests pass: [https://github.com/xwp/wp-theme-nav-
 menu-widget-sidebar-permutations/blob/master/tests
 /nav_menus_switch_from_nav-menus-primary-secondary_to_nav-menus-top-
 footer.sh nav_menus_switch_from_nav-menus-primary-secondary_to_nav-menus-
 top-footer.sh]

 These tests are a level above the unit tests in [attachment:39692.3.diff]
 (which are still needed) and more in the realm of acceptance testing,
 which is really going to be the only feasible way to test menu switching
 in the Customizer.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39692#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform