[wp-trac] [WordPress Trac] #41560: WP_Filesystem_FTPext class documentation updates

WordPress Trac noreply at wordpress.org
Fri Aug 4 10:47:06 UTC 2017


#41560: WP_Filesystem_FTPext class documentation updates
----------------------------+------------------------------
 Reporter:  upadalavipul    |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Filesystem API  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:  docs
----------------------------+------------------------------
Changes (by swissspidy):

 * keywords:   => needs-patch
 * type:  defect (bug) => enhancement
 * component:  General => Filesystem API


Comment:

 We have #41057 to update the entire codebase according to our PHP coding
 standards.

 Cleaning up a single file without any tests or anything is quite
 dangerous. I'd leave that to this ticket and only focus on inline
 documentation here (like the title suggests). Otherwise it's really hard
 to review such an enormous patch.

 @upadalavipul Note that in your patch the indentation is wrong (spaces vs.
 tabs) and there's no parameter description.

 Please consult the PHP documentation standards:
 https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41560#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list