[wp-trac] [WordPress Trac] #41457: WP_REST_Comments_Controller::check_read_post_permission() counts an uncountable value

[WordPress Trac]

#41457: WP_REST_Comments_Controller::check_read_post_permission() counts an
uncountable value
-------------------------------------------------+-------------------------
 Reporter:  johnbillion                          |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.9
Component:  Comments                             |     Version:  4.7
 Severity:  normal                               |  Resolution:
 Keywords:  needs-unit-tests has-patch needs-    |     Focuses:  rest-api
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by johnbillion):

 For clarification: This method currently causes the PHP 7.2 build to fail
 due to the use of `count()` with an uncountable value. We want to avoid
 counting an uncountable value so PHP 7.2 doesn't throw an error.

 What I think we need is somebody to say, yes, we have all of the possible
 types for this variable covered in the tests so we can apply the patch
 from @ayeshrajans.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41457#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform