[wp-trac] [WordPress Trac] #36961: wp_roles displays incorrect roles in multisite

[WordPress Trac]

#36961: wp_roles displays incorrect roles in multisite
-------------------------------------------------+-------------------------
 Reporter:  ryanduff                             |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.9
Component:  Role/Capability                      |     Version:  4.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:  multisite
  note                                           |
-------------------------------------------------+-------------------------
Changes (by flixos90):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests needs-
     dev-note
 * status:  assigned => reviewing


Comment:

 Actually, while we're doing these changes, let's do it right.

 [attachment:36961.6.diff] (based on [attachment:36961.4.diff]) introduces
 `WP_User::for_site()` and deprecates `WP_User::for_blog()`. Since the
 method has been changed anyway, let's strive for slowly making our way
 towards the current naming conventions in multisite. This will furthermore
 allow #38645 to use the current naming conventions and still have the
 necessary parity.

 This looks ready, so it should get in. #38645 can then make the adjustment
 that I previously uploaded in [attachment:36961.5.diff]. Both tickets
 together will require a dev-note to inform about the improvements and
 deprecated methods.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36961#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform