[wp-trac] [WordPress Trac] #39677: Introduce capabilities for managing translations
WordPress Trac
noreply at wordpress.org
Wed Aug 2 19:47:10 UTC 2017
#39677: Introduce capabilities for managing translations
-------------------------------------------------+-------------------------
Reporter: flixos90 | Owner: swissspidy
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 4.9
Component: Role/Capability | Version:
Severity: normal | Resolution:
Keywords: has-unit-tests needs-dev-note has- | Focuses:
patch granular-capabilities commit |
-------------------------------------------------+-------------------------
Changes (by flixos90):
* keywords: has-unit-tests needs-dev-note has-patch granular-capabilities
=> has-unit-tests needs-dev-note has-patch granular-capabilities
commit
Comment:
Replying to [comment:14 johnbillion]:
> Remaining question: Should the three cap checks at the top of `update-
core.php` (line 22) be altered to include `update_languages`? Is this
screen usable if a user ''only'' has that cap?
I tested it, with only having the `update_languages` capability (out of
the four updating caps), and it works perfectly fine. Good point bringing
that up. In [attachment:39677.5.diff] I added the necessary check to the
top of `update-core.php` and also to `menu.php` so that the menu item
shows up correctly.
A sidenote: Looking at the `wp-admin/network/menu.php` file, I noticed in
that file only the `update_core` capability is checked. Let's ignore this
here and deal with it in a separate ticket post-merge. I opened #41538 for
this.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39677#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list