[wp-trac] [WordPress Trac] #35293: Emoji Regex in wp_encode_emoji() is wildly inaccurate

[WordPress Trac]

#35293: Emoji Regex in wp_encode_emoji() is wildly inaccurate
--------------------------+-----------------------
 Reporter:  pento         |       Owner:  pento
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.9
Component:  Emoji         |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------

Comment (by pento):

 == TEST 2

 Remove the `u` modifier from the entities regex. It was mistakenly
 included in the original patch, but isn't required.

 '''Data''': https://travis-ci.org/pento/test-41501/builds/260036411

 '''Analysis''':
 - All versions of PHP saw similar results.
 - Slight penalty on en_US posts. Some variation, but generally no more
 than 10%.
 - Range of ~10% penalty on short post to ~10% improvement on de_DE.
 Improves with post length.
 - Range of negligible change to 10% improvement on zh_TW. Improves with
 post length.

 '''Conclusion''': Test 2 should be included. The en_US penalties are lower
 for the most common cases (0% and 1% emoji), and and the additional few ms
 on shorter posts aren't an issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35293#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform