[wp-trac] [WordPress Trac] #41510: Rename site_id to network_id in multisite functions

WordPress Trac noreply at wordpress.org
Tue Aug 1 17:15:32 UTC 2017


#41510: Rename site_id to network_id in multisite functions
----------------------------------------+------------------------------
 Reporter:  spacedmonkey                |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Networks and Sites          |     Version:  3.0
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:  docs, multisite
----------------------------------------+------------------------------

Comment (by flixos90):

 I think it's a good idea to change `$site_id` to `$network_id` everywhere.
 Even more important than the variables though, there are a few occurrences
 even in doc-blocks where the term "site" is used where it should be
 "network". Maybe that could happen through this ticket as well.

 I'd like to highlight though that at this point let's not change
 `$blog_id` to `$site_id`. This should definitely happen at some point, but
 not before the term "site" is not used for a network anywhere anymore.
 Furthermore we need some more site-related functions with "site" instead
 of "blog" in the name for it to make sense (this is something that is
 underway, but happens organically over time).

 To summarize, in the near future a world of `$blog_id/$site_id` for sites
 and `$network_id` for networks is the thing to aim for. This at least
 clears up the double meaning for the term "site".

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41510#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list