[wp-trac] [WordPress Trac] #40590: wp_video_shortcode always adds controls="controls"

[WordPress Trac]

#40590: wp_video_shortcode always adds controls="controls"
-----------------------------------+------------------------------
 Reporter:  paulschreiber          |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  General                |     Version:  4.7.4
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------------
Changes (by psiico):

 * keywords:  has-patch => has-patch 2nd-opinion


Comment:

 Applied your patch to {{{ wp-includes/media.php }}} and the same problem
 keeps arising. Whether it's a self-hosted video or YouTube or Vimeo.


 Replying to [comment:1 subrataemfluence]:
 > {{{#!php
 > [video src="https://www.youtube.com/watch?v=NhheiPTdZCw"
 controls="false"]
 > }}}
 >
 >
 > The patch checks if an attribute called "controls" is set in `$attr`
 with value "false" in order to prevent output of `controls="controls"`
 attribute in the markup.
 >
 > Otherwise it will add above attribute to the markup.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40590#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform