[wp-trac] [WordPress Trac] #40561: Themes upload with an identical theme should provide a "Replace" prompt

[WordPress Trac]

#40561: Themes upload with an identical theme should provide a "Replace" prompt
--------------------------+-----------------------------
 Reporter:  folletto      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Uploading a theme with an "id" (folder name) identical to an existing one
 should ask the user if they want to "Replace" it or "Cancel" the
 operation.

 The issue:

 1. A user uploading an existing theme is currently simply stopped with a
 fail message with no way forward: "Destination folder already exists." and
 "Theme install failed".
 2. To replace the theme, they have to go back manually, delete the theme,
 then re-upload. Which is basically the same as a prompt asking to replace.
 3. The above however isn't possible if the theme is an active theme: the
 user is thus forced to de-activate the theme first, which might mean
 losing customization settings in the process, and even more having a gap
 where the site looks bad.

 Thus we should:

 * Introduce a  "Do you want to replace the existing theme?" prompt.
 * Show which theme is about to be replaced.
 * Add an extra warning if it's an active theme (we should build the
 replacement of an active theme in a safe way, but as we know there's
 always a degree of uncertainty).
 * (ideally) A matching API to provide this functionality.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40561>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform