[wp-trac] [WordPress Trac] #40529: Improve the Dashboard News widget no-js notice

[WordPress Trac]

#40529: Improve the Dashboard News widget no-js notice
---------------------------------------+-----------------------
 Reporter:  afercia                    |       Owner:  afercia
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  4.8
Component:  Widgets                    |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  ui
---------------------------------------+-----------------------
Changes (by afercia):

 * keywords:  has-screenshots => has-screenshots has-patch
 * owner:   => afercia
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.8


Comment:

 Screenshot with the patch applied:

 [[Image(https://cldup.com/T4brWaD0A7.png)]]

 Couple notes:

 I'd propose to remove the `overflow: hidden` property set on the form for
 the configurable widgets, because the focus style around focusable
 elements gets cut-off:

 [[Image(https://cldup.com/W4v_qGIFYQ.png)]]

 The patch uses the CSS class `wp-clearfix` instead of `overflow: hidden`

 The patch removes the selector `#dashboard_primary .dashboard-widget-
 control-form` because it targets the configurable widgets form: the News
 widget (`#dashboard_primary`) is not configurable any longer since the
 Dashboard redesign, so this selector seems a leftover. See [26144] and
 [26230]

 It ''was'' used in WordPress 3.7 and before, for the Primary feed (Dev
 Blog) Widget. At that time, the News widget was the Secondary Feed
 (Planet) Widget. Screenshot from WordPress 3.7:

 [[Image(https://cldup.com/j3BhvaPG4J.png)]]

 To test:
 - disable JavaScript in your browser
 - delete the widget transient, on VVV this can be quickly done via
 `vagrant ssh` and then using `wp transient delete --all`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40529#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform