[wp-trac] [WordPress Trac] #40498: TinyMCE Bug on media modification modal

[WordPress Trac]

#40498: TinyMCE Bug on media modification modal
--------------------------+------------------------
 Reporter:  casshern83fr  |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  TinyMCE       |     Version:  4.7.3
 Severity:  normal        |  Resolution:  duplicate
 Keywords:                |     Focuses:
--------------------------+------------------------
Changes (by ocean90):

 * status:  new => closed
 * resolution:   => duplicate
 * milestone:  Awaiting Review =>


Old description:

> The function use setBaseAndExtent, make crash with version chrome 58,
> https://www.chromestatus.com/feature/5632500684554240
>
> From dev version
> tinymce\classes\dom\Selection.js
>
> Line 644:                               // WebKit egde case selecting
> images works better using setBaseAndExtent when the image is floated
>         Line 645:                               if (!rng.collapsed &&
> rng.startContainer == rng.endContainer && sel.setBaseAndExtent &&
> !Env.ie) {
>         Line 650:
> sel.setBaseAndExtent(
>         Line 657:
> // Since the setBaseAndExtent is fixed in more recent Blink versions we
>         Line 662:
> sel.setBaseAndExtent(node, 0, node, 1);
>
> tinymce\js\tinymce\tinymce.js (5 hits)
>
> // WebKit egde case selecting images works better using setBaseAndExtent
> when the image is floated
>         Line 18266:                             if (!rng.collapsed &&
> rng.startContainer == rng.endContainer && sel.setBaseAndExtent &&
> !Env.ie) {
>         Line 18271:
> sel.setBaseAndExtent(
>         Line 18278:
> // Since the setBaseAndExtent is fixed in more recent Blink versions we
>         Line 18283:
> sel.setBaseAndExtent(node, 0, node, 1);
>
> // WebKit egde case selecting images works better using setBaseAndExtent
> when the image is floated
>         Line 18266:                             if (!rng.collapsed &&
> rng.startContainer == rng.endContainer && sel.setBaseAndExtent &&
> !Env.ie) {
>         Line 18271:
> sel.setBaseAndExtent(
>         Line 18278:
> // Since the setBaseAndExtent is fixed in more recent Blink versions we
>         Line 18283:
> sel.setBaseAndExtent(node, 0, node, 1);

New description:

 The function use setBaseAndExtent, make crash with version chrome 58,
 https://www.chromestatus.com/feature/5632500684554240

 From dev version
 tinymce\classes\dom\Selection.js


 {{{
 Line 644:                               // WebKit egde case selecting
 images works better using setBaseAndExtent when the image is floated
 Line 645:                               if (!rng.collapsed &&
 rng.startContainer == rng.endContainer && sel.setBaseAndExtent && !Env.ie)
 {
 Line 650:
 sel.setBaseAndExtent(
 Line 657:                                                               //
 Since the setBaseAndExtent is fixed in more recent Blink versions we
 Line 662:
 sel.setBaseAndExtent(node, 0, node, 1);
 }}}


 tinymce\js\tinymce\tinymce.js (5 hits)

 {{{

 // WebKit egde case selecting images works better using setBaseAndExtent
 when the image is floated
 Line 18266:                             if (!rng.collapsed &&
 rng.startContainer == rng.endContainer && sel.setBaseAndExtent && !Env.ie)
 {
 Line 18271:
 sel.setBaseAndExtent(
 Line 18278:                                                             //
 Since the setBaseAndExtent is fixed in more recent Blink versions we
 Line 18283:
 sel.setBaseAndExtent(node, 0, node, 1);
 // WebKit egde case selecting images works better using setBaseAndExtent
 when the image is floated
 Line 18266:                             if (!rng.collapsed &&
 rng.startContainer == rng.endContainer && sel.setBaseAndExtent && !Env.ie)
 {
 Line 18271:
 sel.setBaseAndExtent(
 Line 18278:                                                             //
 Since the setBaseAndExtent is fixed in more recent Blink versions we
 Line 18283:
 sel.setBaseAndExtent(node, 0, node, 1);
 }}}

--

Comment:

 Duplicate of #40305.

 Hello @casshern83fr, welcome to WordPress Trac!

 Thanks for your report. This issue will be fixed in WordPress 4.7.4, which
 [https://make.wordpress.org/core/2017/04/18/4-7-4-release-candidate/
 release is planned for today].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40498#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform