[wp-trac] [WordPress Trac] #40489: Add network ID parameter to wp_is_large_network()

WordPress Trac noreply at wordpress.org
Thu Apr 20 00:41:04 UTC 2017


#40489: Add network ID parameter to wp_is_large_network()
----------------------------------------+------------------------
 Reporter:  flixos90                    |       Owner:  flixos90
     Type:  enhancement                 |      Status:  assigned
 Priority:  normal                      |   Milestone:  4.8
Component:  Networks and Sites          |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  multisite
----------------------------------------+------------------------
Changes (by flixos90):

 * keywords:  needs-patch => has-patch needs-unit-tests
 * owner:   => flixos90
 * status:  new => assigned


Comment:

 [attachment:40489.diff] adds the `$network_id` parameter to the function
 as well as to the filter. Are there any objections to doing that in the
 way it happens in that patch, or in general?

 We should definitely add thorough unit tests for both the function as well
 as different usages of the filter to verify things work as expected.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40489#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list