[wp-trac] [WordPress Trac] #40458: Cannot retrieve custom site details values
WordPress Trac
noreply at wordpress.org
Sat Apr 15 11:50:15 UTC 2017
#40458: Cannot retrieve custom site details values
--------------------------------+------------------------
Reporter: ocean90 | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.8
Component: Networks and Sites | Version: 4.6
Severity: normal | Resolution:
Keywords: has-patch | Focuses: multisite
--------------------------------+------------------------
Comment (by ocean90):
Replying to [comment:2 flixos90]:
> It actually feels more like an enhancement to me, but since it was
possible prior, it's probably a bug.
Yeah, it's kinda both. It's an enhancement to the new site details
handling and a bug if we want to promote `get_site()` as a direct
replacement for `get_blog_details()`.
> I think we should split the unit test into two parts, one for the
`__isset()` and one for `__get()` to have one assertion per test.
Done in [attachment:40458.2.patch], also includes a test for a default
property.
> Let's deal with that in a separate ticket, okay?
Sure, created #40459.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40458#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list