[wp-trac] [WordPress Trac] #38653: Trigger a doing it wrong when checking a role name as a capability

WordPress Trac noreply at wordpress.org
Fri Apr 14 21:19:39 UTC 2017


#38653: Trigger a doing it wrong when checking a role name as a capability
-------------------------------------------------+-------------------------
 Reporter:  johnbillion                          |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  low                                  |   Milestone:  Awaiting
Component:  Role/Capability                      |  Review
 Severity:  normal                               |     Version:
 Keywords:  needs-patch needs-unit-tests good-   |  Resolution:
  first-bug needs-refresh                        |     Focuses:
-------------------------------------------------+-------------------------
Changes (by johnbillion):

 * keywords:  needs-patch needs-unit-tests good-first-bug => needs-patch
     needs-unit-tests good-first-bug needs-refresh


Comment:

 Thanks for the patch, @fibonaccina! The check needs to continue to work as
 it has previously (without the `return false`) so code that is checking
 role names doesn't stop working but still triggers the doing it wrong
 notice.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38653#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list