[wp-trac] [WordPress Trac] #39758: menu-item-home does not get class current-menu-item (not consistent with live page)

WordPress Trac noreply at wordpress.org
Wed Apr 12 20:46:59 UTC 2017


#39758: menu-item-home does not get class current-menu-item (not consistent with
live page)
-------------------------------------------------+-------------------------
 Reporter:  Liddika                              |       Owner:
     Type:  defect (bug)                         |  adamsilverstein
 Priority:  normal                               |      Status:  assigned
Component:  Customize                            |   Milestone:  4.7.4
 Severity:  normal                               |     Version:  4.7
 Keywords:  needs-testing has-patch needs-       |  Resolution:
  refresh                                        |     Focuses:
-------------------------------------------------+-------------------------
Changes (by adamsilverstein):

 * keywords:  needs-testing has-patch => needs-testing has-patch needs-
               refresh


Comment:

 Hi @priyankabehera155 thanks for your patch!

 This seems like a good solution, thanks also for checking that it also
 resolves @jipmoors issue (and @jipmoors, thanks for catching that!). Can
 you please refresh the patch with
 [https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/php/#indentation tabs instead of spaces] and also maybe add a
 comment line above the conditional explaining why the code is there?
 Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39758#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list