[wp-trac] [WordPress Trac] #39205: Replace is_super_admin() check with current_user_can( 'upgrade_database' )

WordPress Trac noreply at wordpress.org
Fri Apr 7 11:23:57 UTC 2017


#39205: Replace is_super_admin() check with current_user_can( 'upgrade_database' )
-------------------------------------------------+-------------------------
 Reporter:  dhanendran                           |       Owner:  flixos90
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.8
Component:  Role/Capability                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note has-unit-   |     Focuses:  multisite
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by flixos90):

 * keywords:  has-patch needs-dev-note has-unit-tests 2nd-opinion => has-
     patch needs-dev-note has-unit-tests


Comment:

 [attachment:39205.2.diff] uses a more specific `upgrade_network`
 capability, as mentioned above. That capability is also used for the menu
 page in the network administration panel, which was missed in the previous
 patch.

 @johnjamesjacoby I like the idea of passing an ID to it, however we should
 follow these efforts in a separate ticket in the future where we can
 investigate more granular network capabilities in general. It should not
 be a problem to adjust the existing capabilities in a backward-compatible
 way, since we can always pre-fill with the current network if none is
 passed to it. Feel free to open one (it would fit well into this list:
 https://core.trac.wordpress.org/query?status=accepted&status=assigned&status=new&status=reopened&status=reviewing&id=29213%2C31020%2C33240%2C38652%2C39083%2C39084%2C39156%2C39677&col=id&col=summary&col=status&col=owner&col=priority&col=milestone&col=version&order=priority)!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39205#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list