[wp-trac] [WordPress Trac] #25344: Introduce *_network_meta() functions

WordPress Trac noreply at wordpress.org
Fri Apr 7 04:29:11 UTC 2017


#25344: Introduce *_network_meta() functions
--------------------------------+-----------------------------
 Reporter:  jeremyfelt          |       Owner:
     Type:  enhancement         |      Status:  reopened
 Priority:  normal              |   Milestone:  Future Release
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  reporter-feedback   |     Focuses:  multisite
--------------------------------+-----------------------------

Comment (by johnjamesjacoby):

 [https://core.trac.wordpress.org/attachment/ticket/25344/25344.5.patch
 25344.5.patch] is the same as .4, but...

 * `ms-functions.php` needs to be included earlier, because the new
 `_network_meta()` functions live there
 * `meta.php` needs to be included earlier, so `get_network_option()` can
 get the `site_name` data from `ms-settings.php`
 * `formatting.php` needs to included earlier, because the meta-data API
 uses `sanitize_key()`

 This looks scarier than it actually is.

 * None of the functions in these (or the surrounding) files are pluggable
 * The include-order in `wp-settings.php` is a mine-field anyways
 * It's a Christmas miracle we haven't had any problems including `ms-
 blogs.php` before `ms-functions.php`
 * Since meta is a thing that primary objects interact with, I'm OK making
 it available sooner, and if this turns out to be a mistake for some
 reason, there's no way for plugins or themes to get in this early anyways

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25344#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list