[wp-trac] [WordPress Trac] #37053: Ensure `get_site_by_path()` returns a `WP_Site`

WordPress Trac noreply at wordpress.org
Fri Sep 30 04:09:19 UTC 2016


#37053: Ensure `get_site_by_path()` returns a `WP_Site`
--------------------------------------+------------------------------
 Reporter:  flixos90                  |       Owner:  jeremyfelt
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  4.7
Component:  Networks and Sites        |     Version:  4.6
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  docs, multisite
--------------------------------------+------------------------------
Changes (by jeremyfelt):

 * keywords:  has-patch has-unit-tests needs-testing => has-patch has-unit-
     tests


Comment:

 Replying to [comment:2 flixos90]:
 > [attachment:37053.2.diff] is an updated patch, including a unit test for
 when using the filter to short-circuit.

 This looks great, thanks @flixos90. I removed the removal of the `todo`
 doc. We should address that in another ticket with the docs in the
 paragraph just above as well. There are some things that are still
 relevant and some that aren't.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37053#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list