[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-----------------------------+------------------------------
 Reporter:  davidakennedy    |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Themes           |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+------------------------------

Comment (by davidakennedy):

 Replying to [comment:2 obenland]:

 Thanks for taking a look!

 > Looks like a decent first pass, we should talk about the API and
 function naming though.

 Yeah, I know you mentioned during some in some previous feedback that we
 should consider writing an abstraction layer with no function names not
 reliant on image or video naming, right? I didn't worry about that with
 this because just thinking about how the functions would be the same or
 different for videos helped me learn and process everything. It should be
 simpler though.

 > In the current form it will not be backwards compatible with older
 themes but displays the video UI in the Customizer.
 > Could you add an example implementation that a theme would use? How are
 things like height/width enforced?

 Right – do you have any suggestions for how best to handle back compat?

 > In terms of feedback about the patch: We shouldn't introduce new
 constants for jit theme support, it's a new feature. I saw a few
 formatting issues but those are minor. Fleshing out the API will take a
 bit more work.

 I can fix this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform