[wp-trac] [WordPress Trac] #38181: Add oEmbed support for Amazon Kindle Instant Previews

[WordPress Trac]

#38181: Add oEmbed support for Amazon Kindle Instant Previews
------------------------------------------------------+--------------------
 Reporter:  jsepia                                    |       Owner:
     Type:  enhancement                               |      Status:  new
 Priority:  normal                                    |   Milestone:  4.7
Component:  Embeds                                    |     Version:  trunk
 Severity:  normal                                    |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-tests  |     Focuses:
------------------------------------------------------+--------------------

Comment (by jsepia):

 Replying to [comment:8 morganestes]:
 > In [[attachment:38181.2.diff]]:
 > - updated to branch off of [38367]
 > - moved the main URL RegEx inside the class as a static variable
 > - updated formatting for the callback `switch` statement
 > - added docs to the filter to add Amazon Kindle
 > - changed `@since` version to 4.7.0
 >
 > Tested locally with
 https://read.amazon.com/kp/embed?asin=B00RZDEKVA&preview=newtab&linkCode=kpe&ref_=cm_sw_r_kb_dp_YPg7xbGKSPV24,
 but needs unit tests for full range of URL possibilities.

 Thanks for cleaning up the patch!

 Replying to [comment:9 ocean90]:
 > @jsepia Could you please answer
 [https://make.wordpress.org/core/handbook/contribute/design-decisions
 /#whitelisting-oembed-providers the questions on whitelisting providers]?
 This will help us in the decision process.

 Sure. I'll have to consult my team leads on some of the questions. In the
 meantime, could you clarify:

 > Is its oEmbed endpoint [...] '''properly documented'''?

 What kind of documentation does this question refer to? Can you provide
 some examples? I've read through
 [https://core.trac.wordpress.org/ticket/37466 a couple of]
 [https://core.trac.wordpress.org/ticket/28597 past oEmbed whitelisting
 tickets] but I was unable to find documentation on any of the providers.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38181#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform