[wp-trac] [WordPress Trac] #35101: image_default_link_type option not being respected
WordPress Trac
noreply at wordpress.org
Wed Sep 28 20:21:59 UTC 2016
#35101: image_default_link_type option not being respected
-------------------------------------------+-------------------------
Reporter: ben1390 | Owner: azaozz
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Media | Version: 4.4
Severity: normal | Resolution: worksforme
Keywords: has-patch needs-testing close | Focuses:
-------------------------------------------+-------------------------
Comment (by ytilis):
Does no one else see the glaring problem with having Wordpress "remember"
your last used image settings?
Let's say you like using {{{Large}}} sized images. Most of your images are
big so this isn't a problem. But if at any point an image too small to
generate a {{{Large}}} size gets added, suddenly {{{Full Size}}} becomes
your default, because your REAL default, the one you actually want,
happened to not exist for the last image. So your preferred settings now
change unexpectedly and without warning, forcing users to constantly make
sure their default image size is the one they actually want.
Additionally, the snippet provided to "fix" this issue falls victim to
this problem as well. The moment you have an image that doesn't support
your default enter the picture, it overrides the user setting all over
again causing {{{Full Size}}} to be your default until you load the page
again, so you also need to add a listener to {{{$('.media-upload-
form').on('click.uploader')}}} and change it there too just to get it
working consistently.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35101#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list