[wp-trac] [WordPress Trac] #37448: Primary and secondary buttons need to reset the outline property

WordPress Trac noreply at wordpress.org
Wed Sep 28 19:53:09 UTC 2016


#37448: Primary and secondary buttons need to reset the outline property
----------------------------------------+----------------------
 Reporter:  afercia                     |       Owner:  afercia
     Type:  defect (bug)                |      Status:  closed
 Priority:  normal                      |   Milestone:  4.7
Component:  Administration              |     Version:
 Severity:  normal                      |  Resolution:  fixed
 Keywords:  needs-patch good-first-bug  |     Focuses:  ui
----------------------------------------+----------------------
Changes (by afercia):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38672"]:
 {{{
 #!CommitTicketReference repository="" revision="38672"
 Administration: Improve the usage of the button CSS classes.

 Introduces some consistency in the usage of the button CSS classes, fixes
 the
 focus style for accessibility and responsiveness of the buttons.

 - Adds the `button` class to all primary buttons make them responsive
 - Removes all `secondary-button` classes and replaces it with button when
 needed. `button-secondary` shouldn't be used and exists just for backward
 compatibility reasons
 - Replaces classes inside `submit_button()` with a shorthand for some
 buttons, and use an empty string for the default `button` class. Passing
 `button` is unnecessary
 - Adjusts `get_submit_button()` to remove empty items

 Props iseulde, dimchik, chris_d2d, mhowell, afercia.
 Fixes #27314, #37138, #37448.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37448#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list