[wp-trac] [WordPress Trac] #38170: get_comment_reply_link(): access to args field 'max_depth' even if not set?

WordPress Trac noreply at wordpress.org
Wed Sep 28 04:11:56 UTC 2016


#38170: get_comment_reply_link(): access to args field 'max_depth' even if not set?
--------------------------+---------------------------
 Reporter:  d4z_c0nf      |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.7
Component:  Comments      |     Version:  4.6.1
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.7


Comment:

 Hi @d4z_c0nf - Thanks for the ticket!

 Yes, I think you're right that there should be a default defined here. In
 practice, the function is generally used in the context of
 `wp_list_comments()`, which passes in its default 'max_depth' parameters.
 But it seems like a reasonable idea to have a sanity check here.

 Introduced in [8878].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38170#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list