[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers
WordPress Trac
noreply at wordpress.org
Tue Sep 27 18:09:05 UTC 2016
#38172: Enable Video Headers in Custom Headers
-----------------------------+------------------------------
Reporter: davidakennedy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Themes | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses:
-----------------------------+------------------------------
Changes (by obenland):
* version: => trunk
Comment:
Looks like a decent first pass, we should talk about the API and function
naming though.
In the current form it will not be backwards compatible with older themes
but displays the video UI in the Customizer.
Could you add an example implementation that a theme would use? How are
things like height/width enforced?
In terms of feedback about the patch: We shouldn't introduce new constants
for jit theme support, it's a new feature. I saw a few formatting issues
but those are minor. Fleshing out the API will take a bit more work.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list