[wp-trac] [WordPress Trac] #37825: Introduce functions to check whether there are multiple taxonomy terms

WordPress Trac noreply at wordpress.org
Sun Sep 25 20:08:49 UTC 2016


#37825: Introduce functions to check whether there are multiple taxonomy terms
------------------------------------------+------------------------------
 Reporter:  flixos90                      |       Owner:
     Type:  enhancement                   |      Status:  new
 Priority:  normal                        |   Milestone:  Awaiting Review
Component:  Themes                        |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  needs-unit-tests needs-patch  |     Focuses:
------------------------------------------+------------------------------

Comment (by DrewAPicture):

 Replying to [comment:5 boonebgorges]:
 > > Actually, most recent default themes did.
 >
 > Point taken :)
 >
 > > About the underscore prefix, when was this decided?
 >
 > I don't know of a specific time or where it's written down. It's been
 personally conveyed to me a number of times. @DrewAPicture can you chime
 in on this? Even if we were sticking with the underscore convention, it's
 not obvious to me why the cache-clearing function would qualify as
 something "private" or "to-be-deprecated" - we'll always need to clear the
 cache.

 I don't know that we're specifically "moving away from" the convention –
 maybe more-so in areas where the underscore is kind of moot, e.g. private
 methods or properties.

 I'd be in favor of underscore-prefixing this new helper mostly for
 consistency. For instance, we've introduced new cache priming helpers with
 the underscore prefix as recently as 4.4 (`_prime_comment_caches()`) and
 4.6 (`_prime_network_caches()`).

 Does that answer your question(s)?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37825#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list