[wp-trac] [WordPress Trac] #37873: Consolidate customizer CSS
WordPress Trac
noreply at wordpress.org
Sat Sep 24 10:22:34 UTC 2016
#37873: Consolidate customizer CSS
----------------------------------------+---------------------------
Reporter: helen | Owner: mrahmadawais
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.7
Component: Customize | Version:
Severity: minor | Resolution:
Keywords: good-first-bug needs-patch | Focuses: ui
----------------------------------------+---------------------------
Comment (by mrahmadawais):
Replying to [comment:4 celloexpressions]:
> Thanks for volunteering to take this on @mrahmadawais!
> I think the first step is to research duplication of styles and
duplication of selectors, and to evaluate the potential areas where things
could be consolidated. We're probably best off adding any new common
classes as opposed to removing any, to avoid JS issues and minimize back-
compat concerns.
Makes sense.
>Any changes will have compatibility implications due to the ability to
extend the core UI with custom panels, sections, and controls. In general,
we should move away from the `accordion-` classes as those are from UI
that is no longer used.
Let me look into it.
> I believe that `customize-nav-menus.css` was largely duplicated from
`customize-widgets.css` and intended to all be merged into `customize-
controls.css` when the menu customizer plugin merged, but that didn't
happen with all of the other work that was ongoing at that time.
> There are also numerous pending patches that would be impacted by these
changes. Depending on how much we want to clean up, it may be best to work
on an actual patch during 4.7 RC and commit early for 4.8.
> Also, previously and related: #30618, #36733, #30713.
I think early 4.8 would make a lot more sense. But I will slowly start
looking into it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37873#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list