[wp-trac] [WordPress Trac] #34391: Harden panel/section UI code by removing contents from being logically nested (read: goodbye margin-top hacks)

[WordPress Trac]

#34391: Harden panel/section UI code by removing contents from being logically
nested (read: goodbye margin-top hacks)
-----------------------------+--------------------------------------------
 Reporter:  westonruter      |       Owner:  delawski
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  4.7
Component:  Customize        |     Version:  4.0
 Severity:  normal           |  Resolution:  fixed
 Keywords:  early has-patch  |     Focuses:  ui, accessibility, javascript
-----------------------------+--------------------------------------------
Changes (by westonruter):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38648"]:
 {{{
 #!CommitTicketReference repository="" revision="38648"
 Customize: Re-architect and harden panel/section UI logic.

 Removes contents for sections and panels from being logically nested (in
 the DOM) in order to eliminate many issues related to using `margin-top`
 hacks. The element containing the link to expand the content element for
 panels and sections is now a sibling element to its content element: the
 content is removed from being nested at initialization. The content
 element is now available in a `contentContainer` property whereas the head
 element (containing the link to open the construct) is in a
 `headContainer` property. The existing `container` property is now a
 jQuery collection that contains both of these elements. Since the head
 element is no longer in an ancestor element to the `content` element, the
 `aria-owns` property is now used to maintain the relationship between the
 `headContainer` and the `contentContainer`. These changes are also
 accompanied by an improvement to the animation performance for the sliding
 panes.

 Props delawski, celloexpressions.
 Fixes #34391.
 Fixes #34344.
 Fixes #35947.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34391#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform