[wp-trac] [WordPress Trac] #20491: Introduce some JavaScript i18n functions
WordPress Trac
noreply at wordpress.org
Fri Sep 23 12:09:23 UTC 2016
#20491: Introduce some JavaScript i18n functions
--------------------------------------+-----------------------------
Reporter: johnbillion | Owner: swissspidy
Type: enhancement | Status: assigned
Priority: normal | Milestone: Future Release
Component: I18N | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses: javascript
--------------------------------------+-----------------------------
Comment (by swissspidy):
Replying to [comment:40 ocean90]:
> Replying to [comment:38 swissspidy]:
> > > * I wonder if we should make `wp.i18n.sprintf()` public or if there
should be a wrapper instead. Something like `wp.i18n.translate( 'Foo %1$s,
%2$s', arg1, arg2 )` as an alternative for `wp.i18n.sprintf( wp.i18n.__(
'Foo %1$s, %2$s', 'domain' ), arg1, arg2 )`.
> >
> > That sounds impossible with the optional domain param before the args,
no?
>
> You're right…
Apparently Jed's `sprintf` implementation is simply a copy of the one from
https://github.com/alexei/sprintf.js. We should rather use that directly
(in `wp-util`, in a new ticket). In the meantime I'll remove the
`wp.i18n.sprintf` line from the patch
--
Ticket URL: <https://core.trac.wordpress.org/ticket/20491#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list