[wp-trac] [WordPress Trac] #37661: A New Experience for Discovering, Installing, and Previewing Themes in the Customizer
WordPress Trac
noreply at wordpress.org
Thu Sep 22 18:23:24 UTC 2016
#37661: A New Experience for Discovering, Installing, and Previewing Themes in the
Customizer
-------------------------------------+-------------------------------------
Reporter: celloexpressions | Owner: celloexpressions
Type: feature request | Status: assigned
Priority: high | Milestone: 4.7
Component: Customize | Version: 4.2
Severity: normal | Resolution:
Keywords: has-patch has- | Focuses: ui, accessibility,
screenshots needs-testing needs- | javascript
user-testing |
-------------------------------------+-------------------------------------
Comment (by celloexpressions):
Thanks for testing @rabmalin! Both buttons become "Installing" since
neither can be used while the install is happening. However, it is kind of
odd UI; does anyone have suggestions here? Maybe change the other button
to `disabled`, while the other button gets the loading indicator? They're
both getting the existing handling from `updates.js` currently.
I fixed a few bugs in [attachment:37661.3.diff]:
- Fix theme updates hiding update message on success.
- Update theme count when themes are deleted.
- Fix theme installation error handling as reported by @rabmalin -
requires another patch to `updates.js`.
I also want to note again that the CSS and JS may cache fairly
persistently; clear the cache and hard reload your browser if you aren't
seeing the UI apply correctly (the top level theme heading should look the
same as before the patch; if it doesn't, you're not getting the new CSS).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37661#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list