[wp-trac] [WordPress Trac] #37447: Remove redundant `is_multisite()` checks in network admin templates

WordPress Trac noreply at wordpress.org
Fri Sep 16 05:49:53 UTC 2016


#37447: Remove redundant `is_multisite()` checks in network admin templates
----------------------------+------------------------
 Reporter:  flixos90        |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  4.7
Component:  Administration  |     Version:  3.1
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  multisite
----------------------------+------------------------
Changes (by jeremyfelt):

 * keywords:  has-patch commit => has-patch


Comment:

 I think we're okay to remove these. It seems (IMO) like part of [16272]
 was about applying some consistency to network admin files that didn't
 have both the `is_multisite()` check and the bootstrap documentation. It
 doesn't really hurt to to have the 2 checks, but the opportunity to reduce
 code is nice. :)

 Is there a way we can work in a one line comment above the check in `wp-
 admin/network/admin.php` to clarify its importance?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37447#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list