[wp-trac] [WordPress Trac] #22058: Improve custom background properties UI

[WordPress Trac]

#22058: Improve custom background properties UI
-------------------------------------+-------------------------------------
 Reporter:  grapplerulrich           |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  4.7
Component:  Customize                |     Version:  3.4.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  ui, accessibility,
  has-screenshots                    |  administration
-------------------------------------+-------------------------------------
Changes (by celloexpressions):

 * keywords:  has-ui-feedback needs-patch needs-screenshots => has-patch
     needs-refresh has-screenshots


Comment:

 Great work here @cdog, I reviewed the patch and didn't see any major
 issues. A couple of suggested changes:
 - Require and register the position control at the top of each
 corresponding block of customize controls, since it's most closely related
 to the base control (and we shouldn't separate the site icon control from
 the cropped image control that it extends).
 - Omit the `settings` parameter when adding the `background_repeat`
 control, since the setting id matches the control id and will be set
 automatically.

 It looks like the new file for the background position control was missed
 in the patch; could you try remaking the patch file to include that?
 Everyone testing will get a fatal error without that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22058#comment:66>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform