[wp-trac] [WordPress Trac] #20899: is_home() should be able to be true when is_feed()

[WordPress Trac]

#20899: is_home() should be able to be true when is_feed()
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.7
Component:  Query                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by swissspidy):

 Regarding my previous comment, Daniel did not exaggerate.

 [attachment:20899.3.diff] makes the patch apply cleanly against trunk
 again. As you can see from the changed tests, this affects a few queries.

 So if anyone's simply checking for `is_home()` to modify the query or
 something, they would likely need to add an `&& is_feed()` check to it.
 But we don't know without more testing, right?

 Is anyone not comfortable with testing this in trunk to see how this
 affects things?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/20899#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform