[wp-trac] [WordPress Trac] #37960: Support for selecting radio buttons in media views

WordPress Trac noreply at wordpress.org
Thu Sep 15 03:32:17 UTC 2016


#37960: Support for selecting radio buttons in media views
-------------------------------------+-------------------------------------
 Reporter:  Enchiridion              |       Owner:  joemcgill
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Media                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch reporter-      |     Focuses:  javascript,
  feedback                           |  administration
-------------------------------------+-------------------------------------
Changes (by joemcgill):

 * keywords:  has-patch => has-patch reporter-feedback
 * owner:   => joemcgill
 * status:  new => reviewing


Comment:

 Hi @Enchiridion – thanks for the report and patch!

 A small detail, `wp-includes/js/media-views.js` is built from several
 files in `wp-includes/js/media/views/` using Browserify via the `grunt
 browserify` command. In this case, we also need to update `/wp-
 includes/js/media/views/settings.js`.

 [attachment:37960.2.patch] applies the same change to both files.

 @Enchiridion could you add a code snippet showing how you're adding the
 radio buttons so it's easier for others to test?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37960#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list