[wp-trac] [WordPress Trac] #37305: Custom Logo: output invalid according to the W3C
WordPress Trac
noreply at wordpress.org
Tue Sep 13 19:03:12 UTC 2016
#37305: Custom Logo: output invalid according to the W3C
--------------------------+------------------------------
Reporter: henry.wright | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Themes | Version: 4.5
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+------------------------------
Comment (by markcallen):
I think making assumptions about the output is inappropriate. There are
circumstances where
* itemptype "Brand" is inappropriate. It may be marking up for
"Organization" for example.
* It is inappropriate to wrap it in anything. The rest of the schema for a
type may be included already - this is afterall, just one part of the
"Brand" type.
It would be more appropriate to remove the itemprop attributes from the
link and img tag and provide a facility for developers to add them
(filters and/or function args).
In any event, the `get_custom_logo` filter that is in place at present
provides the ability to wrap the output of the function in the "Brand" (or
anything else) markup if that is appropriate for a theme developer.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37305#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list