[wp-trac] [WordPress Trac] #38024: fs_unavailable while auto-updating several plugins in a row

[WordPress Trac]

#38024: fs_unavailable while auto-updating several plugins in a row
-----------------------------+------------------------------
 Reporter:  benjaminniess    |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  4.6.1
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+------------------------------

Comment (by ronalfy):

 I know where the problem lies, just not enough time to dig in completely
 atm.

 The problem is easy to duplicate through the code.

 It starts in `wp-admin/includes/class-wp-automatic-upgrader.php`.

 On line 392, the `foreach` is run for the available plugins/themes to
 update. [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/class-wp-automatic-updater.php#L392 Source]

 On line 330 is the call for the `upgrade` method for the appropriate
 plugins or themes. [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/class-wp-automatic-updater.php#L330 Source].

 Using plugins as an example, in `wp-admin/includes/class-plugin-
 upgrader.php` on line 172/174
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /class-plugin-upgrader.php#L174 (Source)] is the call to the clear the
 plugin cache and run the `run` method for the `WP_Upgrader` parent class.
 Note that `is_multi` is not being sent as an argument.

 In `wp-admin/includes/class-wp-upgrader.php`, since `is_multi` is false,
 it runs the action `upgrader_process_complete` after the first iteration
 of a plugin or theme. [https://core.trac.wordpress.org/browser/trunk/src
 /wp-admin/includes/class-wp-upgrader.php#L759 Source], which I believe is
 clearing the plugin cache and causing the errors.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38024#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform